CompatHelper: bump compat for SolverCore to 0.3, (keep existing compat) #222
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sshin23
force-pushed
the
compathelper/new_version/2022-09-10-00-37-00-337-04281866383
branch
from
5810906
to
773f330
Compare
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
==========================================
+ Coverage 74.31% 75.67% +1.35%
==========================================
Files 38 38
Lines 3703 3453 -250
==========================================
- Hits 2752 2613 -139
+ Misses 951 840 -111
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…rsion/2022-09-10-00-37-00-337-04281866383
There was a problem hiding this comment.
Looks good to me!
I should think about this, but I am wondering if MadNLPExecutionStats should be an attribute in MadNLPSolver. It just stores duplicate information, and we are using it only to return the solution of a particular optimization problem. The question is: what difference it would make if instead we create MadNLPExecutionStats only when the solver has converged (and define it as an immutable struct)?
|
@frapac thanks for the review! For the execution stats, we're following the JSO's convention, which considers |
frapac
deleted the
compathelper/new_version/2022-09-10-00-37-00-337-04281866383
branch
This pull request changes the compat entry for the
SolverCorepackage from~0.1,~0.2to~0.1,~0.2, 0.3.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.